-
Notifications
You must be signed in to change notification settings - Fork 32
Uncheck 'Select all' header cell on page change #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncheck 'Select all' header cell on page change #1196
Conversation
Hi @klaraloreen EDIT(@lkiesow ): Klara did submit an ICLA to Apereo. It usually takes a while for Apereo to process the submissions. Meanwhile, please ignore the ICLA test and point reviewers to this comment if anyone asks on further pull requests. |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/1196/2025-05-22_14-37-07/ . |
Looks good for pagination. But I found another problem:
|
Hi @klaraloreen, thanks for your work.
Thanks & BR |
This pull request has conflicts ☹ |
Hi @ferishili, thanks for your improvements! I removed the state variable and used the deselect method instead, just like you suggested. |
Thanks, @klaraloreen, [UPDATE]: It is decided; the correct way in terms of UX is to deselect all items even when we change the number of rows per page, therefore, we need to take care of that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klaraloreen, please consider adding forceDeseletAll()
in this method as well:
const changePageSize = (size: number) => { |
Hi @ferishili, thanks for your suggestion! I added the method to force deselection on change of the page size. Sorry for the late reply! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @klaraloreen
Fixes: #1193.
Adds a state variable to control the value of the "Select all" header cell on page change.
Screenshot before issue (page just changed):

Screenshot after issue (page just changed):
